[VUFIND88] RESULTS PAGE EMAIL THIS DOESNT WORK WITH JAVASCRIPT

[VUFIND-88] Results page "Email This" doesn't work with javascript turned off Created: 23/Sep/09  Updated: 30/Sep/09  Resolved: 30/Sep/09

Status:

Closed

Project:

VuFind

Component/s:

Search

Affects Version/s:

1.0RC1, 1.0RC2

Fix Version/s:

1.0RC2

Type:

Bug

Priority:

Trivial

Reporter:

Eoghan Ó Carragáin

Assignee:

Andrew Nagy

Resolution:

Fixed

Votes:

0

Labels:

None

Environment:

Windows, SVN r1349

With javascript on, the link that is sent with this email is generated by services/search/ajax.js ( "url=" + URLEncode(window.location.href) + "&" +). When javascript is off , this variable is not available. The email sends but no link is included.

I wonder if this is something that Greg Pendlebury's search object would handle easily. If not, I can look at passing the URL parameters to Search/Email and parsing them in services/search/email.php. Or is there a simpler solution?

In the meantime I am displaying a <noscript /> warning to users.
Cheers

Comment by Demian Katz [ 30/Sep/09 ]

r1531 includes a simple fix for this issue that uses the HTTP referer to determine the URL for the email. It throws a fatal error if no referer is found (unlikely, but possible due to an oddball browser or security-conscious user... not sure how much overlap there is between no JS and no referer). The Search Object is probably a better long-term solution, but this fix should serve to fill the gap for the moment; at least it prevents users from thinking they've successfully sent emails when in fact they haven't!